Skip to content

Return nullptr from impSimdAsHWIntrinsic if the baseline ISA has been marked as disabled - #37272

Merged
tannergooding merged 1 commit into
dotnet:masterfrom
tannergooding:fix-37260
Jun 2, 2020
Merged

Return nullptr from impSimdAsHWIntrinsic if the baseline ISA has been marked as disabled#37272
tannergooding merged 1 commit into
dotnet:masterfrom
tannergooding:fix-37260

Conversation

@tannergooding

Copy link
Copy Markdown
Member

This resolves #37260

@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jun 1, 2020
@tannergooding

Copy link
Copy Markdown
Member Author

CC. @CarolEidt, @BruceForstall, @echesakovMSFT

@tannergooding

Copy link
Copy Markdown
Member Author

The remaining failures are slightly different.

  • A handful of tests fail because they expect the relevant System.Numerics method to have not been compiled, but COMPlus_EnableSSE2=0 or COMPlus_EnableSSE=0 blocks that. These tests should likely be updated...
  • A couple of tests are failing because tree->gtType != TYP_STRUCT. This is on Vector256<T> tests when AVX2 is disabled

Working on fixing these, if there hasn't been sign-off yet I'll add them to this PR otherwise I will get up a new PR.

@CarolEidt CarolEidt left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks!

@CarolEidt

Copy link
Copy Markdown
Contributor

A handful of tests fail because they expect the relevant System.Numerics method to have not been compiled, but COMPlus_EnableSSE2=0 or COMPlus_EnableSSE=0 blocks that. These tests should likely be updated...

The way this is tested is a bit of a hack, and there may be a better way to test that an intrinsic has been recognized, but it's not immediately obvious what that would be.

@tannergooding
tannergooding merged commit ec6bec4 into dotnet:master Jun 2, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Assertion failed 'compIsaSupportedDebugOnly(InstructionSet_SSE2)'

3 participants